Add cibuildwheel config #270
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 24 24
Lines 2222 2222
=======================================
Hits 1924 1924
Misses 298 298 ☔ View full report in Codecov by Sentry. |
maxnoe
force-pushed
the
build_wheels
branch
5 times, most recently
from
386f5ee to
9b76f9c
Compare
|
I am happy with the test results, seems to work properly now, so I reverted the debugging steps and made it again so it only publishes on tags. |
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-20.04, windows-2019, macOS-11] |
There was a problem hiding this comment.
Does it matter that we build everything on ubuntu as a test for linux instead of alma? It's not super relevant for this PR, I am asking because that question was raised in the simtools context.
There was a problem hiding this comment.
The base image for the linux build doesn't matter at all. Since the actual build happens another layer down in the "manylinux" docker images, which are actually based on centos:
There was a problem hiding this comment.
We don't have a choice here, binary wheels delivered to pypi must follow these standards.
We can then test if the wheels build that way run correctly on our reference system, which they should.
There was a problem hiding this comment.
OK, that answers the question also for simtools then. We can do all of the building in ubuntu, even building the containers, and just make sure that the tests (unit and integration) run well in the alma container.
There was a problem hiding this comment.
simtools itself is not a compiled module, so the story is different (much simpler, since you upload a platform-independet wheel to pypi).
The question how to compile the needed binary tools by simpipe is different.
Try using cibuildwheel so we can eventually publish wheels to pypi automatically.