-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with FoV offset binnning when using energy dependant theta cut and diffuse MC #1328
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
==========================================
- Coverage 73.52% 73.51% -0.01%
==========================================
Files 134 134
Lines 14215 14215
==========================================
- Hits 10451 10450 -1
- Misses 3764 3765 +1 ☔ View full report in Codecov by Sentry. |
@moralejo This is the new PR. Now test are working, but the codecov check are failling. I'm not sure what I need to change. |
fov_offset_bins = [mean_fov_offset - 0.1, mean_fov_offset + 0.1] * u.deg | ||
else: | ||
fov_offset_bins = self.data_bin.fov_offset_bins() | ||
self.log.info("Multiple offset for diffuse gamma MC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you can print in the log the binning (might be somewhere else, but better be explicit on what it is doing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added in the log line the FoV binning used.
codecov is not strictly required. I think you would have to cover a larger part of the code with CI tests |
This PR fix the issue #1322 . The bloc of code managing the FoV binning as been moved too.
The PR also add a warning message if the FoV binning is wider than the simulated FoV, and restrict the gammas used for the computation of energy dependant cuts (gh and theta) to the ones within the FoV range considered for the IRF.