Pin scikit-learn to 1.2.x #1326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use the same sklearn version used for producing the models as for their application
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
=======================================
Coverage 73.52% 73.52%
=======================================
Files 134 134
Lines 14215 14215
=======================================
Hits 10451 10451
Misses 3764 3764 ☔ View full report in Codecov by Sentry. |
|
But with the change minor releases 1.2.x will not be used either, right? (is that intended?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a new lstchain installation, usually the sklearn version ends up being later than 1.2.x (setup.py requires
=~1.2, which will install the latest 1.x version), the one used to produce existing RF models. One needs to use the same sklearn version in dl1 to dl2 as the one used to produce the models.