Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test file #1291

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Replace test file #1291

merged 5 commits into from
Nov 21, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 17, 2024

New file is not yet on the data server, but will be there tomorrow

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@morcuended
Copy link
Member

@maxnoe is the new test file already in the data server?

@maxnoe
Copy link
Member Author

maxnoe commented Oct 1, 2024

No, not yet. @kosack had some issues connecting to the server, but I think they are solved now.

But he's on vacation until the 4th

@morcuended
Copy link
Member

@maxnoe, @kosack, a friendly reminder for the replacement of the test file.

@maxnoe maxnoe force-pushed the replace_test_file branch from a1fc29c to 310da26 Compare November 6, 2024 14:25
@maxnoe
Copy link
Member Author

maxnoe commented Nov 6, 2024

Test file is now there, let's see

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (cfd9a7f) to head (c025849).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/reco/r0_to_dl1.py 0.00% 1 Missing ⚠️
lstchain/scripts/lstchain_mc_r0_to_dl2.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
+ Coverage   73.50%   73.52%   +0.01%     
==========================================
  Files         134      134              
  Lines       14211    14215       +4     
==========================================
+ Hits        10446    10451       +5     
+ Misses       3765     3764       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@morcuended
Copy link
Member

Maybe add a test for r0 to dl1 script running without input argument to make sure it works in the future.

@morcuended morcuended marked this pull request as ready for review November 12, 2024 18:02
@morcuended
Copy link
Member

Added a test to check that running the script without input argument also works. I think this is good to go.

@moralejo moralejo merged commit 8a62ad1 into main Nov 21, 2024
8 of 9 checks passed
@moralejo moralejo deleted the replace_test_file branch November 21, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running lstchain_mc_r0_to_dl1 with default gamma_test_large.simtel.gz fails
3 participants