-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace test file #1291
Replace test file #1291
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@maxnoe is the new test file already in the data server? |
No, not yet. @kosack had some issues connecting to the server, but I think they are solved now. But he's on vacation until the 4th |
a1fc29c
to
310da26
Compare
Test file is now there, let's see |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 73.50% 73.52% +0.01%
==========================================
Files 134 134
Lines 14211 14215 +4
==========================================
+ Hits 10446 10451 +5
+ Misses 3765 3764 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Maybe add a test for r0 to dl1 script running without input argument to make sure it works in the future. |
Added a test to check that running the script without input argument also works. I think this is good to go. |
New file is not yet on the data server, but will be there tomorrow