Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of post_DL3_analysis notebook #1262

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Update of post_DL3_analysis notebook #1262

merged 3 commits into from
Nov 15, 2024

Conversation

moralejo
Copy link
Collaborator

A bit of clean-up.
Made the Content Summary consistent with the actual contents.
Changed excess vs. sqrt(t) to excess vs. t (which is what is meaningful for a steady flux).
Moved all the light curve calculations after the SED ones. It is not needed to re-do everything just to change the light curve energy range.

Made the Content Summary consistent with the actual contents.
Changed excess vs. sqrt(t) to excess vs. t (which is what is meaningful
for a steady flux).
Moved all the light curve calculations after the SED ones. It is not needed
to re-do everything just to change the light curve energy range.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (e097079) to head (c029ec7).
Report is 181 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   73.05%   73.50%   +0.45%     
==========================================
  Files         134      134              
  Lines       14039    14211     +172     
==========================================
+ Hits        10256    10446     +190     
+ Misses       3783     3765      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo
Copy link
Collaborator Author

This has been tested with the 2024 LST analysis school Crab data under /fefs/aswg/workspace/analysis-school-2024/DL3/Crab_Dec_2023

@moralejo moralejo marked this pull request as ready for review June 11, 2024 15:09
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
notebooks/post_DL3_analysis.ipynb Show resolved Hide resolved
@morcuended
Copy link
Member

I'll implement the comments

@moralejo
Copy link
Collaborator Author

@morcuended did you do those changes? Were they related to the changes I introduced, or just general improvements of the notebook? (if the latter they should be in another PR for clarity)

@morcuended
Copy link
Member

morcuended commented Jul 30, 2024

I have to go through it again. I will probably do the changes in another PR to not keep this pending forever

@moralejo moralejo requested a review from morcuended November 7, 2024 13:17
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the pending modifications. Sorry for taking so long. Further improvements and updates can be done in other PRs. I also updated DL3 files to be able to use Gammapy 1.2

@morcuended morcuended added the ready for review Pull request is ready for review label Nov 13, 2024
Copy link
Contributor

@chaimain chaimain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In the next changes, I would suggest replacing the mention of OGIP files and simply use the standard method used in Gammapy to write DL4/5files (with the gadf format)

Edit: Also Gammapy allows getting the pivot energy for any spectral model. Perhaps it is better to also mention the example in Gammapy to get EBL-deabsorbed spectra

@morcuended
Copy link
Member

morcuended commented Nov 13, 2024

Looks good. In the next changes, I would suggest replacing the mention of OGIP files and simply use the standard method used in Gammapy to write DL4/5files (with the gadf format)

Edit: Also Gammapy allows getting the pivot energy for any spectral model. Perhaps it is better to also mention the example in Gammapy to get EBL-deabsorbed spectra

Yes, but I think that can be updated later. The EBL de-absorbed will be for 1.3. The pivot energy for any spectral model can be done already with 1.2.

I opened an issue (#1315) to list all these points. Plus those you told me some time ago.

@moralejo moralejo merged commit ee03691 into main Nov 15, 2024
9 checks passed
@moralejo moralejo deleted the post_dl3 branch November 15, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants