-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of post_DL3_analysis notebook #1262
Conversation
Made the Content Summary consistent with the actual contents. Changed excess vs. sqrt(t) to excess vs. t (which is what is meaningful for a steady flux). Moved all the light curve calculations after the SED ones. It is not needed to re-do everything just to change the light curve energy range.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
+ Coverage 73.05% 73.50% +0.45%
==========================================
Files 134 134
Lines 14039 14211 +172
==========================================
+ Hits 10256 10446 +190
+ Misses 3783 3765 -18 ☔ View full report in Codecov by Sentry. |
This has been tested with the 2024 LST analysis school Crab data under |
I'll implement the comments |
@morcuended did you do those changes? Were they related to the changes I introduced, or just general improvements of the notebook? (if the latter they should be in another PR for clarity) |
I have to go through it again. I will probably do the changes in another PR to not keep this pending forever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the pending modifications. Sorry for taking so long. Further improvements and updates can be done in other PRs. I also updated DL3 files to be able to use Gammapy 1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. In the next changes, I would suggest replacing the mention of OGIP files and simply use the standard method used in Gammapy to write DL4/5files (with the gadf format)
Edit: Also Gammapy allows getting the pivot energy for any spectral model. Perhaps it is better to also mention the example in Gammapy to get EBL-deabsorbed spectra
Yes, but I think that can be updated later. The EBL de-absorbed will be for 1.3. The pivot energy for any spectral model can be done already with 1.2. I opened an issue (#1315) to list all these points. Plus those you told me some time ago. |
A bit of clean-up.
Made the Content Summary consistent with the actual contents.
Changed excess vs. sqrt(t) to excess vs. t (which is what is meaningful for a steady flux).
Moved all the light curve calculations after the SED ones. It is not needed to re-do everything just to change the light curve energy range.