Add unit tests and run them in the CI action #25
Conversation
… compare the numpy arrays.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
morcuended
changed the title
| if P1_limits == "None": | ||
| P1_limits = None | ||
| if P2_limits == "None": | ||
| P2_limits = None | ||
| if P3_limits == "None": | ||
| P3_limits = None |
There was a problem hiding this comment.
For another PR, we should improve this None, "None" comparison. Right now it keeps the code as it was after the ruff formating.
|
Thanks @cpozogonzalez for the implementation and changes. They look good overall. Just have a concern about the usage of unittest instead of pytest and some small comments and checks for you to perform. |
Co-authored-by: Daniel Morcuende <[email protected]>
There was a problem hiding this comment.
All the changes proposed by @morcuended have been fixed. I will be create a new issue to review the exceptions and decide which is the error to catch.
There was a problem hiding this comment.
Thanks for the clarifications @cpozogonzalez. Looks good to me.
1- Add unit test. Using tutorial data.
2- Implement CI to run the test in commit stage.
3- Config ruff to autorun in pre-commit stage.
4- Apply all of the ruff linter changes.