Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lab4 #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Lab4 #28

wants to merge 4 commits into from

Conversation

Pfat8equalsD
Copy link
Contributor

No description provided.

catalin-rucareanu2001
catalin-rucareanu2001 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@catalin-rucareanu2001 catalin-rucareanu2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn t test it on the board yet

DTeodor-Alexaandru
DTeodor-Alexaandru requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@DTeodor-Alexaandru DTeodor-Alexaandru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename .v and .xdc file, task0 -> fsm_ba and task1 -> traffic_lights, or any other suggestions that you have

@DTeodor-Alexaandru
Copy link
Contributor

DTeodor-Alexaandru commented Oct 30, 2024 •
edited
Loading

Take a look at the written content and check for mistakes like:

  • "atribuiri non-blocante: =="
  • wrong link to solution

@DTeodor-Alexaandru
Copy link
Contributor

Looks good, didn t test it on the board yet

Please don't approve without proper review

@DTeodor-Alexaandru
Copy link
Contributor

@Pfat8equalsD Please make the requested changes to merge this PR asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DTeodor-Alexaandru DTeodor-Alexaandru DTeodor-Alexaandru requested changes

@catalin-rucareanu2001 catalin-rucareanu2001 catalin-rucareanu2001 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/drills kind/new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pfat8equalsD @DTeodor-Alexaandru @catalin-rucareanu2001