Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm getrandom dep #53

Merged
merged 2 commits into from
Nov 27, 2023
Merged

rm getrandom dep #53

merged 2 commits into from
Nov 27, 2023

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Nov 27, 2023

this dep enables the "js" Cargo feature but that should not be done in libraries

closes #51

japaric and others added 2 commits November 27, 2023 14:53
@japaric
rm getrandom dep
f066e70 
this dep enables the "js" Cargo feature but that should not be done in
libraries
@franziskuskiefer
Merge branch 'main' into rm-getrandom-js
b6f1fad
franziskuskiefer
franziskuskiefer approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franziskuskiefer franziskuskiefer merged commit f2a5b1a into cryspen:main Nov 27, 2023
13 of 14 checks passed
@japaric japaric deleted the rm-getrandom-js branch November 27, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getrandom's "js" feature should not be enabled in libraries
2 participants
@japaric @franziskuskiefer