Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup toast for unread announcements, can mark announcements as read #207

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Popup toast for unread announcements, can mark announcements as read #207

merged 6 commits into from
Jul 23, 2024

Conversation

NamitBhutani
Copy link
Member

Fixes #205

kishan1735
kishan1735 reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@kishan1735 kishan1735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except for one thing. Given id isn't a part of announcementType isn't it better to create a new Type

skoriop
skoriop approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skoriop skoriop added the ready Ready to be merged (used by our GitHub Actions pipeline) label Jul 23, 2024
@skoriop skoriop added this pull request to the merge queue Jul 23, 2024
Merged via the queue into master with commit 3395bcc Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishan1735 kishan1735 kishan1735 left review comments

@skoriop skoriop skoriop approved these changes

Assignees
No one assigned
Labels
ready Ready to be merged (used by our GitHub Actions pipeline)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pop-up when new announcement is made
3 participants
@NamitBhutani @kishan1735 @skoriop