Feat: Allow Update Channel Reward to accept strings, variables, and event metadata #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds more options to the Update Channel Reward effect to allow users to manually enter the UUID or name of the reward to update, use replace variables such as
$rewardId, or, if the effect is added directly to the effects in the Channel Reward in Firebot, or in one of the 3 Channel Reward events, they may opt for the ID to automatically be pulled from the Event MetadataApplicable Issues
n/a
Testing
Comprehensively tested the new functionality by specifying strings, variables and Associated Reward in all applicable locations. Also tested that legacy uses of the effect will still function with the major changes to how it operates, and opening old instances of the effect to edit will automatically convert the now defunct settings to the newer ones