chore: refactor settings access #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuel38
pushed a commit
to Samuel38/Firebot
that referenced
this pull request
Dec 27, 2024
* settings refactor wip * refactor backend settings * refactor frontend settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Create new
SettingsManagerclass, migrated settings access to new class, and all direct disk access is done only on the backend. Frontend settings access now uses IPC.Important
SettingsManagernow uses strongly-typed values for all known Firebot settings, using the newgetSettingandsaveSettingmethods. Previous methods have been deprecated and all methods that aren't already documented in the script types library have been removed.Applicable Issues
No open issue, but hopefully this will finally solve intermittent issues with settings file becoming corrupt
Testing
Opened every main settings section, validated many settings would load/save correctly
Screenshots
N/A