Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vars chore/fix: Hide Deprecated Variables and Update Variable Data Typings #2929

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

phroggster
Copy link
Collaborator

Description of the Change

  • Hide every ReplaceVariable that is marked as deprecated.
    • They've lived a good life. but it's an appropriate time.
  • Correct, or specify with greater precision, several possibleDataOutput property values in variable definitions.
  • Update several variable descriptions to be more consistent, better-formatted, or otherwise fix some plain ol' misspellings.

Applicable Issues

N/A

Testing

"Yup"

Screenshots

N/A

- These were marked deprecated back in January, 2024.
- They still function like they had, they just won't show up in the
  variables list drop-down.
- Correct, or better specify, result data typings for deprecated vars:
  - `$rawBitsLeaderboard`
  - `$rawCustomRoleUsers`
  - `$rawTopBitsCheerers`
  - `$rawUsernameArray`
  - `$rawUserRoles`
- And fix two minor misspellings:
  - `$rawArrayFilter`: twitch -> which
  - `$rawBitsLeaderBoard`: $bitsLoaderboard -> $bitsLeaderboard
- Update several variable descriptions to be more consistent, and
  address a couple of misspellings.
- Correct/better-specify result data typings for variables:
  - `$bitsLeaderboard`
  - `$rawGiftReceivers`
  - `$rawTopCurrency`
  - `$rawTopMetadata`
  - `$rawTopViewTime`
  - `$subNames`
  - `$topBitsCheerers`
  - `$usernameArray`
  - `$userRoles`
@phroggster phroggster requested a review from ebiggz as a code owner December 15, 2024 07:41
@zunderscore zunderscore merged commit b3ba364 into crowbartools:v5 Dec 24, 2024
1 check passed
@phroggster phroggster deleted the hide-deprecated-vars branch December 25, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants