Add deb and rpm builds for distribution #2895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcreech
force-pushed
the
add-rpm-deb-builds
branch
from
09b861f to
5739a3e
Compare
pcreech
force-pushed
the
add-rpm-deb-builds
branch
from
5739a3e to
266eacf
Compare
This adds the ability to generate rpm and deb packages as part of linux distribution. It takes advantage of other electron-installer based providers while building an electron app.
pcreech
force-pushed
the
add-rpm-deb-builds
branch
from
266eacf to
29df94f
Compare
|
marking blocked until build issues resolved to prevent accidental early merges. |
|
So, after doing some more testing, setting the deb build to amd64 instead of x86_64, it looks like AppArmor is not an issue on my Ubuntu 24.04 install when installed through the .deb package. The .tar.gz currently still throws the SUID helper error. |
|
I've added a contribution PR to your fork that fixes debian builds, adds some icons and consolidates and explicitly defines some settings. All info available at pcreech#1 |
|
Further testing required: does this work with -beta and -nightly.DATE builds? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to generate rpm and deb packages as part of linux distribution. It takes advantage of other electron-installer based providers while building an electron app.
Description of the Change
It would be nice to have a native rpm or deb package for installing to a distribution. This is an initial attempt to add this functionality to the build system.
Applicable Issues
Testing
The initial testing was to ensure the app was basically functional post-install on an rpm system (fedora). I still need to verify functionality on a debian based system, but I wanted to also start getting feedback and start conversations around approach and outputs.
Screenshots