This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[cca]Add the [email protected] for cca #3836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuzhong
changed the title
|
But what about testing the newer version in future? |
|
Add a text to store the cordova-android version? |
|
Can we expose a param for specific version of cordova-android? |
|
Yes. I think that's a good way. |
|
Updated, PTAL |
Honry
reviewed
Nov 7, 2016
| @@ -181,7 +181,7 @@ def create(appname, pkgname, mode, sourcecodepath, replace_index_list, self, ext | |||
| do_remove(glob.glob(os.path.join(project_root, "www"))) | |||
| do_copy(sourcecodepath, os.path.join(tool_path, appname, "www")) | |||
|
|
|||
| def buildGoogleApp(appname, sourcecodepath, self): | |||
| def buildGoogleApp(appname, sourcecodepath, self, cordova_android_ver = "6.0.0"): | |||
There was a problem hiding this comment.
I don't think make default value "6.0.0" is a good point, just ignore it. And pass specific version in the param.
There was a problem hiding this comment.
That will require the calling of this function more than 1 place.
Add cordova-android 6.0.0 explicitly for cca build. Impacted tests(approved): new 0, update 2, delete 0 Unit test platform: Crosswalk Project for Android 23.53.589.0 Unit test result summary: pass 2, fail 0, block 0 BUG=https://crosswalk-project.org/jira/browse/CTS-1916
qiuzhong
force-pushed
the
CTS-1916
branch
2 times, most recently
from
554f1fe
to
1e691b9
Compare
|
@Honry , updated |
|
@haoxli, please also take a look. |
|
Prefer to add cordova-android version following the version of cordova-plugin-crosswalk-webview, not fix it as 6.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cordova-android 6.0.0 explicitly for cca build.
Impacted tests(approved): new 0, update 2, delete 0
Unit test platform: Crosswalk Project for Android 23.53.589.0
Unit test result summary: pass 2, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/CTS-1916