Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): Ignore AvailabilityZone if MultiAZ is set #1909

Merged

Conversation

MisterMX
Copy link
Collaborator

Description of your changes

Only pass spec.forProvider.availabilityZone during update calls if spec.forProvider.multiAZ is false.

Fixes #1870

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit tests

@MisterMX MisterMX requested a review from chlunde October 13, 2023 14:28
@MisterMX MisterMX force-pushed the fix/database-multiaz-skip-az branch from 62398f9 to 61de770 Compare October 13, 2023 14:31
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
@MisterMX MisterMX force-pushed the fix/database-multiaz-skip-az branch from 61de770 to e592356 Compare October 13, 2023 14:40
@chlunde
Copy link
Collaborator

chlunde commented Oct 13, 2023

nice!

@github-actions
Copy link

Successfully created backport PR #1913 for release-0.44.

@MisterMX MisterMX deleted the fix/database-multiaz-skip-az branch October 19, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants