This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
Tidy up code for remembering the IDP #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyhd
suggested changes
Mar 3, 2017
app/main/views/auth.py
Outdated
| dept = [profile['name'] | ||
| for profile in idp_profiles if idp_name == profile['idp_name']] | ||
| if dept: | ||
| return ' or '.join(dept) |
There was a problem hiding this comment.
Arbitrary indentation level on line 101. But rather than using a list comprehension, consider using a for loop instead - list comprehensions are less readable. Also, since the callers of this function do not handle a None return value, the check on line 102 is redundant. Eg:
dept_names = []
for profile in idp_profiles:
if idp_name == profile['idp_name']:
dept_names.append(profile['name'])
return ' or '.join(dept_names)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactored the gateway code dealing with remembering the IDP to make it clearer
How to review
Look at the code in app/main/views/auth.py
Execute run-tests to ensure that code changes do not break the website