Make vagrant in CI available #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
|
/approve |
saschagrunert
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
vagrant
branch
from
d4b8a40 to
e35bab2
Compare
saschagrunert
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
saschagrunert
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Ready for review. PTAL @cri-o/cri-o-maintainers |
kwilczynski
reviewed
Dec 16, 2024
Comment on lines
+4
to
+5
| curl -fsSL https://apt.releases.hashicorp.com/gpg | gpg --dearmor -o /usr/share/keyrings/hashicorp-archive-keyring.gpg | ||
| echo "deb [signed-by=/usr/share/keyrings/hashicorp-archive-keyring.gpg] https://apt.releases.hashicorp.com $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/hashicorp.list |
There was a problem hiding this comment.
A small nit. On Debian, the /etc/apt/keyrings directory would be for user-managed files.
This is not a blocker.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The vagrant package does not seem to be available any more, so we use them from HashiCorp.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?