Add a FIFO/LIFO IRedeemOptimizer realisation. #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
As discussed with @lucasia thus:
To Do
IRedeemOptimizer
that encapsulates the above strategy.RedeemOptimizer
base realisation to encapsulate common behaviours.IMultiTokenVault
to include theERC1155Supply
exists(uint256 id)
, because:IRedeemOptimizer
to seamlessly track the first period that has any deposits against it. This is the typical starting point of optimisation.Replaces #123