Yield upgradeable #118
Merged
Yield upgradeable #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yield upgradeable
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
lucasia
reviewed
Oct 3, 2024
packages/contracts/.solhint.json
Outdated
| @@ -8,6 +8,7 @@ | |||
| "func-name-mixedcase": "off", | |||
| "var-name-mixedcase": "off", | |||
| "no-console": "off", | |||
| "one-contract-per-file": "off" | |||
| "one-contract-per-file": "off", | |||
| "no-empty-blocks": "off" | |||
packages/contracts/lib/forge-std
Outdated
There was a problem hiding this comment.
please revert this - we shouldn't need to update forge-std
packages/contracts/remappings.txt
Outdated
There was a problem hiding this comment.
please check remappings. only openzeppelin-contracts-upgradeable should be added.
|
|
||
| bytes32 public constant OPERATOR_ROLE = keccak256("OPERATOR_ROLE"); | ||
| bytes32 public constant PAUSER_ROLE = keccak256("PAUSER_ROLE"); | ||
| bytes32 public constant UPGRADE_ROLE = keccak256("UPGRADE_ROLE"); |
Comment on lines
15
to
23
| // constructor(IERC20Metadata asset, uint256 assetToSharesRatio, uint256 yieldPercentage) | ||
| // { | ||
| // __TimerCheats__init(block.timestamp); | ||
| // __MultiTokenVault_init(asset); | ||
| // ASSET_TO_SHARES_RATIO = assetToSharesRatio; | ||
| // YIELD_PERCENTAGE = yieldPercentage; | ||
| // } | ||
|
|
||
| function initialize(IERC20Metadata asset, uint256 assetToSharesRatio, uint256 yieldPercentage) public initializer { |
Krishnakumarskr
temporarily deployed
to
testnet
GitHub Actions
Inactive
Krishnakumarskr
temporarily deployed
to
Preview
GitHub Actions
Inactive
Krishnakumarskr
temporarily deployed
to
testnet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.