Fix linting - add typed error

credbull · Aug 28, 2024 · f49ccc1 · f49ccc1
1 parent 79139ba
commit f49ccc1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/contracts/test/src/multi/IProduct.s.sol b/packages/contracts/test/src/multi/IProduct.s.sol
@@ -2,6 +2,8 @@
 pragma solidity ^0.8.20;
 
 interface IProduct {
+    error RedeemTimePeriodNotSupported(uint256 currentPeriod, uint256 redeemPeriod);
+
     // ===============  Vault / Vault-like Behavior ===============
 
     /**

diff --git a/packages/contracts/test/src/multi/SimpleInterestVault.s.sol b/packages/contracts/test/src/multi/SimpleInterestVault.s.sol
@@ -78,13 +78,13 @@ contract SimpleInterestVault is IERC4626Interest, SimpleInterest, ERC4626, IProd
         return ERC4626.redeem(shares, receiver, owner);
     }
 
+    // TODO - not fully implemented.   need to unlock the specific shares specific to this period.
     function redeemAtPeriod(uint256 shares, address receiver, address owner, uint256 redeemTimePeriod)
         external
         returns (uint256 assets)
     {
-        // TODO - not sure this method is required...
         if (currentTimePeriodsElapsed != redeemTimePeriod) {
-            revert();
+            revert RedeemTimePeriodNotSupported(currentTimePeriodsElapsed, redeemTimePeriod);
         }
 
         return redeem(shares, receiver, owner);