Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep passing siteId around #296

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Sep 30, 2024

Description

Along with elementId of the nested entry, we also need to keep passing siteId around so that can accurately grab that entry/its draft when editing in a slideout.

Related issues

#295

# Conflicts:
#	src/web/assets/ckeditor/dist/ckeditor5-craftcms.js
#	src/web/assets/ckeditor/dist/ckeditor5-craftcms.js.map
[ci skip]
@brandonkelly brandonkelly merged commit cbbebe2 into 4.x Oct 19, 2024
@brandonkelly brandonkelly deleted the bugfix/295-site-id-adjustments branch October 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants