list plugins were renamed in v41 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/web/assets/ckeditor/dist/ckeditor5-craftcms.js # src/web/assets/ckeditor/dist/ckeditor5-craftcms.js.map
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In CKEditor v40, the
DocumentListplugin got updated to allow for Todo Lists and simple configuration, so we switched to using that plugin and dropped theListplugin.In CKEditor v41, the
DocumentListplugin got renamed toList.The
DocumentListwas set as an alias for theListplugin, which means it works as expected, but it throws a warning.This PR updates our code to use the unaliased, updated
Listplugin.It also removes
MediaEmbedToolbarfrom the list of plugins. At the moment, this plugin throws an error and doesn’t seem to do anything except "serve as a base for custom development”. More info:Related issues
#168