-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New images #56
New images #56
Conversation
I don't think The pieces are nice, but I don't like the knight design - is it supposed to be a blocky saddle? |
Lol, no, that's a horse's head :) I put the image and the source in the commit because it makes it easier for someone to edit them. I certainly wasn't going to try to match 12 bases that were in separate files. Can I make a repo here ( cpluspluscom )? Might be neat to have a developer tools repo. |
Yes, feel free to make a repository here! That's what this organization is for :) |
First would like to say I like the new pieces and I think they would definitely work for the time being. Also I am curious why not use sprite sheets like new_pieces.png instead of single piece textures? Much better to load 1 texture for the pieces then 12. Also the developer tools repo sounds like fun. What exactly do you have planned for it? Like just a collection of useful classes, functions, ect that people can add to and use? Or something else? |
Then we support only an exact set of pieces with no ability to support additional pieces without modifying the image. One of the original goals of the project is modularity and supporting many of the other chess variants. |
I created the repo for you using the subtree split method: |
I made the commit to remove .cpp and image last night, so it appears earlier in this conversation. Thanks for the repo :) |
I think this commit is good to merge despite the knight being a minecraft saddle, just want to get @Thumperrr's and @naraku9333's opinions. |
They look good to me. |
I'm also on board with this. |
Fixes #40
I know they aren't pretty ( but they sure won't fall over ). That is about the best of my ability. It would probably be wise to find a set online that we know we can use without worry.
I also removed the chessboard that was at the wrong rotation.
Making 12 images that are lined up is a PIA so I made a support program to split one png into the 12 that we need. The program requires png++ and libpng, I imagine anyone who wants to use it can manage finding them on his/her own.