Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config webpack for services #340

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Dec 7, 2022

Ce fix permet de patch temporairement le problème avec le package mjml qui ne doit pas être minifié, ou du moins, conserver les noms de ces éléments pour fonctionner.

Exemple d'erreur ... Element mj-head doesn't exist or is not registered ...

Problème déjà rencontré : cozy/create-cozy-app#1339

The main change is the addition of :
```
optimization: {
    minimize: false
  }
```
This temporarily patches the problem with the `mjml` package which does not need to be minified, or at least keep the names of these elements to work
@bundlemon
Copy link

bundlemon bot commented Dec 7, 2022

BundleMon

Files added (2)
Status Path Size Limits
services/expiration/mespapiers.js
+1.81MB -
services/launchTriggers/mespapiers.js
+590.22KB -
Unchanged files (25)
Status Path Size Limits
vendors/mespapiers.(hash).js
2.92MB -
img/IlluPassportDate.(hash).png
38.4KB -
img/IlluPassportNumber.(hash).png
37.98KB -
img/IlluPassport.(hash).png
37.87KB -
vendors-mespapiers.(hash).(hash).min.css
35.15KB -
img/IlluIdCardNumberHelp.(hash).png
13KB -
img/IlluDriverLicenseBack.(hash).png
12.72KB -
img/IlluIdCardFront.(hash).png
12.58KB -
img/IlluIdCardBack.(hash).png
12.43KB -
img/IlluResidencePermitExpirationDateHelp.(ha
sh).png
12.17KB -
img/IlluResidencePermitNumberHelp.(hash).png
12.16KB -
img/IlluIdCardExpirationDateHelp.(hash).png
12.09KB -
img/IlluResidencePermitFront.(hash).png
12.08KB -
img/IlluDriverLicenseNumberHelp.(hash).png
11.93KB -
img/IlluDriverLicenseFront.(hash).png
11.85KB -
img/IlluDriverLicenseObtentionDateHelp.(hash)
.png
11.74KB -
img/IlluResidencePermitBack.(hash).png
11.01KB -
app/mespapiers.(hash).js
10.21KB -
img/IlluVehicleRegistration.(hash).png
8.92KB -
img/IlluDiploma.(hash).png
5.59KB -
img/IlluIBAN.(hash).png
3.81KB -
img/IlluCovidVaccineCertificate.(hash).png
2.96KB -
img/IlluInvoice.(hash).png
2.33KB -
img/icon.(hash).svg
977B -
app-mespapiers.(hash).min.css
219B -

Total files change +2.39MB +73.65%

Groups updated (1)
Status Path Size Limits
**/*.js
5.31MB (+1.35MB +34.02%) -
Unchanged groups (2)
Status Path Size Limits
img/.
284.56KB -
**/*.css
35.37KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Merkur39 Merkur39 merged commit 4b2ad1e into master Dec 7, 2022
@Merkur39 Merkur39 deleted the fix/Update-config-webpack-for-services branch December 7, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants