fix: Redirect with PopupOpener on flagship app #2698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flagship app does not handle a redirection with const newWindow =
window.open('') and then newWindow.location.href. So let's set the
url directly in window.open because we do not know why it was
separated in two.
|
Je close ici, ce composant n'a plus lieu d'être on n'ouvre plus les éléments de cette manière, la solution sera côté app de simplement ouvrir le lien dans un nouvel onglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagship app does not handle a redirection with const newWindow = window.open('') and then newWindow.location.href. So let's set the url directly in window.open because we do not know why it was separated in two.