Skip to content

Commit

Permalink
fix(AppTile): Display the name of the developer instead custom property
Browse files Browse the repository at this point in the history
The properties are adapted only once in the app that consumes the component, to be less specific.

This is a revert of a part of the PR : #2680
  • Loading branch information
cballevre committed Sep 25, 2024
1 parent 6477abe commit ff428f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Array [
"title": "Cozy Photos",
},
Object {
"developer": "By undefined",
"developer": null,
"status": "Update available",
"title": "Tasky",
},
Expand Down
7 changes: 2 additions & 5 deletions react/AppTile/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ export const AppTile = ({

const isInMaintenanceWithSpecificDisplay =
displaySpecificMaintenanceStyle && statusLabel === APP_STATUS.maintenance
const tileSubtitle = isShortcutFile(app)
? app.metadata?.source
: developer.name

return (
<Tile
Expand Down Expand Up @@ -107,8 +104,8 @@ export const AppTile = ({
<TileTitle isMultiline={!statusLabel}>
{namePrefix ? `${namePrefix} ${name}` : name}
</TileTitle>
{showDeveloper && (
<TileSubtitle>{`${t('app_item.by')} ${tileSubtitle}`}</TileSubtitle>
{developer.name && showDeveloper && (
<TileSubtitle>{`${t('app_item.by')} ${developer.name}`}</TileSubtitle>
)}
{statusToDisplay && (
<TileFooter isAccent={statusLabel === APP_STATUS.update}>
Expand Down

0 comments on commit ff428f8

Please sign in to comment.