[VO-1194] feat: Hide shortcut badge when for some context #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the application to crash if a folder was created on Drive while Home was open at the same time. This was due to real time adding the folder but without attributes because it didn't use json-api.
This make the shortcut tile appears more like apps in some case it could be useful
Before, only way to de-group was to click on the switch. Now it's the line in the options menu that does the action (the switch is contained inside). I've taken advantage of this to make the user return to the root when he chooses to ungroup a folder so that he doesn't stay on a route that doesn't display anything. This could lead to strange behaviour when they chose to group it again
zatteo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: