Update abstractdriver.py #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-nagy
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Hi @vsarathy1, this looks good to me - I think its a great move going forward to have this code shared by the Mongo and Couchbase drivers (and indeed, all other drivers that use JSON-like documents). Just some nitpick comments - in particular, one that didn't register with me until today was the shadowing of the built-in tuple.
| @@ -63,6 +63,119 @@ def formatConfig(self, config): | |||
| ret += "\n\n# %s\n%-20s = %s" % (desc, name, default) | |||
| return (ret) | |||
|
|
|||
| def getOneDoc(self, tableName, tuple, generateKey=False): | |||
There was a problem hiding this comment.
nitpick: can we rename the parameter tuple so that it doesn't shadow the Python built-in tuple?
Maybe something like doc_tuple or field_values?
Same goes for getOneCH2Doc, getOneCH2PPDoc, genNestedTuple etc.
Comment on lines
+76
to
+80
| for l, k in enumerate(constants.KEYNAMES[tableName]): | ||
| if l == 0: | ||
| key = str(tuple[k]) | ||
| else: | ||
| key = key + '.' + str(tuple[k]) |
There was a problem hiding this comment.
nitpick: we can write this perhaps more simply as
key = ".".join(str(tuple[k]) for k in constants.KEYNAMES[tableName])
Same in getOneCH2PPDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.