Ruler: Add support for per-user external labels #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
component/rules
damnever
force-pushed
the
feat/external-labels
branch
from
79ff7b1
to
8551250
Compare
Signed-off-by: Xiaochao Dong (@damnever) <[email protected]>
damnever
force-pushed
the
feat/external-labels
branch
from
8551250
to
24be605
Compare
damnever
changed the title
Signed-off-by: Friedrich Gonzalez <[email protected]>
|
@rapphil @rajagopalanand Maybe u guys can take a look on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support for per-user external labels, this currently applies only to alerting rules, but we may consider adding them to remote read in the future.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]