Add remote write v2 proto #6320
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
commented
Nov 7, 2024
| // | ||
| // For Go, see github.com/prometheus/prometheus/model/timestamp/timestamp.go | ||
| // for conversion from/to time.Time to Prometheus timestamp. | ||
| int64 timestamp = 15; |
There was a problem hiding this comment.
At v2, the naming of unix timestamp is converted from timestamp_ms to timestamp for all of (exemplar, sample, and histogram).
So, I re-defined Histogram instead of using the existing one.
SungJin1212
force-pushed
the
Add-remote-write-v2-proto
branch
from
322b5c9
to
6204558
Compare
6 tasks
SungJin1212
force-pushed
the
Add-remote-write-v2-proto
branch
from
6204558
to
6e0054a
Compare
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-remote-write-v2-proto
branch
from
6e0054a
to
ab3963d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6292.
This PR adds remote write v2 proto and
PreallocTimeserieslike v1.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]