This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
pkg/operator: don't erroneously "update" (kill) unhealthy active node #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2018 11:46
More fully describe and simplify the tests `Vaults.syncUpgrade()` uses to determine whether it should trigger the active node to step down. This will hopefully make them easier to understand without any behavioral changes. Log when the active node has been forced to step down. Making it easier to follow the operator's actions.
Previously, any node whose health couldn't be queried by `Vaults.updateLocalVaultCRStatus()` would be removed from the standby, sealed, and updated lists of nodes (so long as at least one other node could be reached and was healthy aka `changed == true`). Thus, if the active node could not be reached and determined healthy it would be removed from `VaultServiceStatus.UpdatedNodes`, but would remain `VaultServiceStatus.VaultStatus.Active`. Later, this would cause `Vaults.syncUpgrade()` to determine that the active node was the only non-updated node and then kill it to "complete" the update it assumed was in progress. Keep note of which nodes have actually been updated irrespective of whether they're reachable and healthy to prevent this issue. Fixes coreos#344
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any node whose health couldn't be queried by
Vaults.updateLocalVaultCRStatus()would be removed from the standby, sealed,and updated lists of nodes (so long as at least one other node could be reached
and was healthy aka
changed == true).Thus, if the active node could not be reached and determined healthy it would be
removed from
VaultServiceStatus.UpdatedNodes, but would remainVaultServiceStatus.VaultStatus.Active.Later, this would cause
Vaults.syncUpgrade()to determine that the active nodewas the only non-updated node and then kill it to "complete" the update it
assumed was in progress.
Keep note of which nodes have actually been updated irrespective of whether
they're reachable and healthy to prevent this issue.
Fixes #344