-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RHELCoreOSExtensions with Azure image URL #16
Conversation
b60347a
to
daa8563
Compare
daa8563
to
5314745
Compare
OK lifting draft, I've tested this in concert with coreos/coreos-assembler#2026 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. If RHCOS stream info is also meant to be supported going forward I recommend eventually updating the README.md
as well.
Remind me again, is the stream metadata for RHCOS going to be a public API, or just for us (where "us" includes |
In order to support e.g. AWS UPI installs, it basically has to be a public API. I mean, the way it works now is that:
Which is obviously, horrendously broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but seems reasonable to me.
I'm okay with the general approach. If we could publish an FCOS VHD to a storage container before we had proper Marketplace support, I'd lean more toward #14, but I think blob uploads are also blocked on coreos/fedora-coreos-tracker#148. I like separating the RHCOS hacks off into an omitempty RHCOS-hack-area; hopefully that'll make them easier to clean up later. |
This contains just a URL for now because that's all the current RHCOS cosa metadata has. I'm trying to add e.g. the Azure Blob storage md5 information as well as the full size+sha256, but in practice this data is just the uncompressed VHD; anyone who wants to do "offline" verification outside of Azure can replicate that. For FCOS we may end up uploading the image too, though we hope there to end up in the Marketplace. For now, let's stick this off an explicit extension area. Closes: coreos#13
5314745
to
66f4438
Compare
OK, addressed comments! |
This contains just a URL for now because that's all
the current RHCOS cosa metadata has. I'm trying
to add e.g. the Azure Blob storage md5 information as
well as the full size+sha256, but in practice this
data is just the uncompressed VHD; anyone who wants
to do "offline" verification outside of Azure can
replicate that.
For FCOS we may end up uploading the image too,
though we hope there to end up in the Marketplace.
For now, let's stick this off an explicit extension area.
Closes: #13