Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHELCoreOSExtensions with Azure image URL #16

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

cgwalters
Copy link
Member

This contains just a URL for now because that's all
the current RHCOS cosa metadata has. I'm trying
to add e.g. the Azure Blob storage md5 information as
well as the full size+sha256, but in practice this
data is just the uncompressed VHD; anyone who wants
to do "offline" verification outside of Azure can
replicate that.

For FCOS we may end up uploading the image too,
though we hope there to end up in the Marketplace.

For now, let's stick this off an explicit extension area.

Closes: #13

@cgwalters cgwalters marked this pull request as draft February 11, 2021 16:04
@cgwalters cgwalters force-pushed the rhcos-azure-extension branch from b60347a to daa8563 Compare February 11, 2021 21:41
@cgwalters cgwalters mentioned this pull request Feb 11, 2021
@cgwalters cgwalters force-pushed the rhcos-azure-extension branch from daa8563 to 5314745 Compare February 11, 2021 21:42
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Feb 11, 2021
@cgwalters cgwalters marked this pull request as ready for review February 11, 2021 21:45
@cgwalters
Copy link
Member Author

OK lifting draft, I've tested this in concert with coreos/coreos-assembler#2026

Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. If RHCOS stream info is also meant to be supported going forward I recommend eventually updating the README.md as well.

@ashcrow ashcrow requested a review from bgilbert February 12, 2021 15:43
@jlebon
Copy link
Member

jlebon commented Feb 12, 2021

Remind me again, is the stream metadata for RHCOS going to be a public API, or just for us (where "us" includes oc, openshift-install, operators, etc...) ?

@cgwalters
Copy link
Member Author

cgwalters commented Feb 12, 2021

In order to support e.g. AWS UPI installs, it basically has to be a public API.

I mean, the way it works now is that:

  • CoreOS team bumps pinned installer
  • docs team later comes along and copies those AMIs into docs
  • Some human doing a UPI (hopefully with custom scripting) pastes the AMIs into their tools

Which is obviously, horrendously broken.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but seems reasonable to me.

stream/rhcos/rhcos.go Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor

I'm okay with the general approach. If we could publish an FCOS VHD to a storage container before we had proper Marketplace support, I'd lean more toward #14, but I think blob uploads are also blocked on coreos/fedora-coreos-tracker#148. I like separating the RHCOS hacks off into an omitempty RHCOS-hack-area; hopefully that'll make them easier to clean up later.

Makefile Outdated Show resolved Hide resolved
release/relrhcos/rhcos.go Outdated Show resolved Hide resolved
This contains just a URL for now because that's all
the current RHCOS cosa metadata has.  I'm trying
to add e.g. the Azure Blob storage md5 information as
well as the full size+sha256, but in practice this
data is just the uncompressed VHD; anyone who wants
to do "offline" verification outside of Azure can
replicate that.

For FCOS we may end up uploading the image too,
though we hope there to end up in the Marketplace.

For now, let's stick this off an explicit extension area.

Closes: coreos#13
@cgwalters cgwalters force-pushed the rhcos-azure-extension branch from 5314745 to 66f4438 Compare February 16, 2021 14:27
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Feb 16, 2021
@cgwalters
Copy link
Member Author

cgwalters commented Feb 16, 2021

OK, addressed comments!

@cgwalters cgwalters merged commit 7c4d5d7 into coreos:main Feb 16, 2021
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Feb 16, 2021
openshift-merge-robot pushed a commit to coreos/coreos-assembler that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define an azure schema
4 participants