Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock: Update(*) #5226

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Cargo.lock: Update(*) #5226

merged 4 commits into from
Jan 16, 2025

Conversation

cgwalters
Copy link
Member

Our dependabot configuration:

  • Splits up each depedency update into a separate PR
  • Is configured to only have outstanding a maximum number of PRs at a certain time

These two things combined with the dependency graph size and rate
of churn mean we are now far behind.

We should change this to how bootc works: Queue all minor updates
into a big PR.

Anyways, let's catch up.

Our dependabot configuration:

- Splits up each depedency update into a separate PR
- Is configured to only have outstanding a maximum number of PRs at a certain time

These two things combined with the dependency graph size and rate
of churn mean we are now far behind.

We should change this to how bootc works: Queue all minor updates
into a big PR.

Anyways, let's catch up.

Signed-off-by: Colin Walters <[email protected]>
@jlebon
Copy link
Member

jlebon commented Jan 15, 2025

Hmm, RPM build failing with

[2025-01-15T19:19:56.228Z] warning: `/home/jenkins/agent/workspace/rpm-ostree_PR-5226/rpm-ostree-2024.9.73.g0c0d9bbc-build/rpm-ostree-2024.9.73.g0c0d9bbc/.cargo/config` is deprecated in favor of `config.toml`
[2025-01-15T19:19:56.228Z] note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
[2025-01-15T19:19:56.228Z] error: failed to get `anyhow` as a dependency of package `rpmostree-rust v0.1.0 (/home/jenkins/agent/workspace/rpm-ostree_PR-5226/rpm-ostree-2024.9.73.g0c0d9bbc-build/rpm-ostree-2024.9.73.g0c0d9bbc)`

@cgwalters
Copy link
Member Author

The source of that is

[2025-01-15T19:19:56.228Z] Caused by:
[2025-01-15T19:19:56.228Z]   failed to parse manifest at `/home/jenkins/agent/workspace/rpm-ostree_PR-5226/rpm-ostree-2024.9.73.g0c0d9bbc-build/rpm-ostree-2024.9.73.g0c0d9bbc/vendor/cxxbridge-cmd/Cargo.toml`

Which came up in coreos/cargo-vendor-filterer#111

…ring

xref coreos/cargo-vendor-filterer#111

This is just a temporary workaround until cxx is fixed.
@cgwalters
Copy link
Member Author

Added a workaround for coreos/cargo-vendor-filterer#111

Everything here is OSI approved.
@cgwalters
Copy link
Member Author

Updated deny.toml both here and in containers/bootc#1035

@cgwalters cgwalters enabled auto-merge January 16, 2025 15:03
@cgwalters cgwalters merged commit 6c0cbf7 into coreos:main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants