app: Add --lock-finalization switch to other commands #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `upgrade` and `deploy` already support this. There's no reason why all the remaining "deployment-creating" commands shouldn't. Prompted by openshift/machine-config-operator#1897 which will need this specifically for `rebase`.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Jul 29, 2020
Thin release. Mostly for a bunch of RHCOS-relevant fixes and enhancements: 752f4f0 (coreos#2178), 4d836dd (coreos#2151) and f608eb0 (coreos#2158).
Merged
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
upgradeanddeployalready support this. There's no reason whyall the remaining "deployment-creating" commands shouldn't. Prompted by
openshift/machine-config-operator#1897 which
will need this specifically for
rebase.