coreos-meta-translator: add gcp cloud launchable to release.json #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As AMIs have their own field
images
under theaws
key, I think it might make sense for GCP to follow the same rule, adding animage
field under thegcp
key and rename the originalimage
key toname
.If this is reasonable, it should be followed by updating
fedora-coreos-stream-generator
to support this PR. Finally, download page could read the GCP cloud launchable metadata from e.g.stable.json
instead ofmeta.json
Related: coreos/fedora-coreos-tracker#494
Signed-off-by: Allen Bai [email protected]