Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-meta-translator: add gcp cloud launchable to release.json #109

Closed
wants to merge 1 commit into from

Conversation

zonggen
Copy link
Member

@zonggen zonggen commented Jun 10, 2020

As AMIs have their own field images under the aws key, I think it might make sense for GCP to follow the same rule, adding an image field under the gcp key and rename the original image key to name.

If this is reasonable, it should be followed by updating fedora-coreos-stream-generator to support this PR. Finally, download page could read the GCP cloud launchable metadata from e.g. stable.json instead of meta.json

Related: coreos/fedora-coreos-tracker#494
Signed-off-by: Allen Bai [email protected]

@zonggen
Copy link
Member Author

zonggen commented Jun 10, 2020

Example JSON field in release.json:

"gcp":{
   "artifacts":{
      "tar.gz":{
         "disk":{
            "location":"https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/31.20200517.3.0/x86_64/fedora-coreos-31.20200517.3.0-gcp.x86_64.tar.gz",
            "signature":"https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/31.20200517.3.0/x86_64/fedora-coreos-31.20200517.3.0-gcp.x86_64.tar.gz.sig",
            "sha256":"e7a766cbba51fc35cb55d471c42ecc824519c6a3bd8a95577749676aeebf9b9c"
         }
      }
   },
   "image":{
      "project":"fedora-coreos-cloud",
      "url":"https://storage.googleapis.com/fedora-coreos-cloud-image-uploads/image-import/fedora-coreos-31-20200517-3-0-gcp-x86-64.tar.gz",
      "family":"fedora-coreos-stable",
      "name":"fedora-coreos-31-20200517-3-0-gcp-x86-64"
   }
}

@bgilbert
Copy link
Contributor

coreos/fedora-coreos-tracker#494 (comment)

@zonggen
Copy link
Member Author

zonggen commented Jun 11, 2020

Closing as we inline to not exposing the GS URL, thanks for the link 👍

@zonggen zonggen closed this Jun 11, 2020
@dustymabe
Copy link
Member

hey @zonggen - I think the only thing we agreed on so far is to not expose the URL - so I think we'd still want the project/family/name.

@dustymabe
Copy link
Member

So, IIUC, something like:

"gcp":{
   "artifacts":{
      "tar.gz":{
         "disk":{
            "location":"https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/31.20200517.3.0/x86_64/fedora-coreos-31.20200517.3.0-gcp.x86_64.tar.gz",
            "signature":"https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/31.20200517.3.0/x86_64/fedora-coreos-31.20200517.3.0-gcp.x86_64.tar.gz.sig",
            "sha256":"e7a766cbba51fc35cb55d471c42ecc824519c6a3bd8a95577749676aeebf9b9c"
         }
      }
   },
   "image":{
      "project":"fedora-coreos-cloud",
      "family":"fedora-coreos-stable",
      "name":"fedora-coreos-31-20200517-3-0-gcp-x86-64"
   }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants