Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildextend-live: always enable miniso #2579

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 24, 2021

Now that we have coreos-installer v0.11.0 in cosa, we can drop the
--miniso switch and always turn it on. The only place which used it is
the coreos-installer CI, which will stop using it once this is merged.

Patch best viewed with whitespace ignored.

Closes: coreos/fedora-coreos-tracker#868

Now that we have coreos-installer v0.11.0 in cosa, we can drop the
`--miniso` switch and always turn it on. The only place which used it is
the coreos-installer CI, which will stop using it once this is merged.

Patch best viewed with whitespace ignored.

Closes: coreos/fedora-coreos-tracker#868
Upstreams can (and should) redefine the scenario set to run if the
default doesn't make sense for them.
@jlebon
Copy link
Member Author

jlebon commented Nov 24, 2021

Also sanity-checked RHCOS:

$ kola testiso -S --scenarios miniso-install
Testing scenarios: [miniso-install]
Ignoring verification of signature on metal image
Successfully tested scenario miniso-install for 410.84.202111241725-0 on bios (metal)

bgilbert
bgilbert previously approved these changes Nov 24, 2021
@jlebon jlebon enabled auto-merge (rebase) November 24, 2021 19:28
@jlebon
Copy link
Member Author

jlebon commented Nov 24, 2021

[2021-11-24T20:13:57.699Z] + coreos-installer iso extract pack-minimal-iso /srv/tmp/buildpost-live/fedora-coreos-35.20211124.dev.0-live.x86_64.iso /srv/tmp/buildpost-live/fedora-coreos-35.20211124.dev.0-live.x86_64.iso.minimal --consume

[2021-11-24T20:13:57.699Z] error: Found argument 'extract' which wasn't expected, or isn't valid in this context

Ahh right OK, it's pulling in v0.10.0. Tagged v0.11.0 into f35-coreos-continuous. Also added a commit to tickle the Quay.io cache!

@jlebon jlebon merged commit 833defd into coreos:main Nov 24, 2021
@jlebon jlebon deleted the pr/miniso-enable-always branch April 22, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support converting the live ISO into a minimal live ISO
2 participants