Add size/md5 to Azure metadata #2038
Conversation
First this changes ore to write a JSON file that the Python side parses, so we don't need to re-synthesize the URL on the Python side. Gather Azure Blob metadata (size+md5) and add that to our metadata, This is mainly useful so that one can use the Azure API to "offline validate" against our metadata snapshot. I'd also like to add our sha256 checksum for consistency, but that can come later. This is prep for coreos/stream-metadata-go#13
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
I think the direction of this PR makes sense, but I'd like to not block on it because it makes everything a lot harder to roll out if we have to respin RHCOS too and can't use the existing metadata. (Well, I guess I could retro-patch the existing metadata, but eh) The value is also fairly low because I think few people are actually going to validate the image offline. |
|
AIUI, users (or tools) won't be interacting with the VHD bits directly, just using them as a copy source within Azure and then creating a VM image from the copy. In that case, since the URL is essentially an identifier, I don't think it's that important to include digests etc.. So yeah, the value seems low to me too. However, I think we should consider uploaded artifacts immutable, if only to reduce confusion. If we need to respin a release, we should just update stream metadata to point to the new image. That's what it's for. 🙂 |
|
@cgwalters: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing as this is Draft for a long time. Re-open if it gets refreshed. |
First this changes ore to write a JSON file that the Python side
parses, so we don't need to re-synthesize the URL on the Python
side.
Gather Azure Blob metadata (size+md5) and add that to our metadata,
This is mainly useful so that one can use the Azure API to "offline validate"
against our metadata snapshot. I'd also like to add our sha256
checksum for consistency, but that can come later.
This is prep for coreos/stream-metadata-go#13