Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests that require creation time on musl #759

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

JustSoup312
Copy link
Contributor

Creation time will only be supported on the musl target once rust-lang/rust#125692 lands.

This MR disables the tests that require creation time for musl.

Creation time will only be supported on the musl target once rust-lang/rust#125692 lands.
Copy link

openshift-ci bot commented Oct 29, 2024

Hi @JustSoup312. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we could probably use mtime here too in practice.

@travier
Copy link
Member

travier commented Nov 5, 2024

/retest ci/prow/test

Copy link

openshift-ci bot commented Nov 5, 2024

@travier: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test test

Use /test all to run all jobs.

In response to this:

/retest ci/prow/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@travier
Copy link
Member

travier commented Nov 5, 2024

/ok-to-test

@cgwalters cgwalters merged commit 493c95f into coreos:main Nov 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants