lock: add etcdv3 semaphore implementation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently based on #4, so it needs that one to land first. |
arithx
reviewed
Apr 24, 2019
lucab
force-pushed
the
ups/etcd3-semaphore
branch
from
3dc3d99 to
b30c17b
Compare
lucab
commented
Apr 25, 2019
|
@arithx thanks for reviewing, I hope the client-config part is a bit more clear now. I actually have one more doubt on key-prefix configuration where I'd like your input. |
arithx
reviewed
Apr 25, 2019
lucab
force-pushed
the
ups/etcd3-semaphore
branch
from
b30c17b to
829c7c1
Compare
|
Rebased on latest master, got rid of the previously embedded #4. |
|
@arithx mind another pass on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports semaphore logic from
locksmith, moving to etcdv3 transactions and cleaning up unused bits.