Add old dynamic relax, tweak to default cfl, docs fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I already cherry-picked your changes on the rebased branch! |
sanguinariojoe
pushed a commit
that referenced
this pull request
Dec 12, 2024
docs: add disable output to the docs and options list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves my comments in FloatingArrayDesign#182
I added the old dynamic relaxation back in if users want it. It is turned on with the flag ICgenDynamic = 1 in the options list. I changed the default CFL behavior so that if CFL is not provided, the user time step is used to calculate it. I adjusted the read_curve function to skip the first three lines of the txt file in accordance with the docs lines section. This matches MDF.
All these changes are also reflected in the docs updates on here.