Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listings and events #468

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

ticruz38
Copy link
Collaborator

Removing calendar events as well as the @Event-calendar dependency.

EventDetail, EventEdit and EventDelete are still accessible via an Event Note so they remain.

#452
#453

@staab staab changed the base branch from master to dev November 12, 2024 16:46
Copy link
Collaborator

@staab staab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and remove the EventActions stuff, and the delete/edit links from EventInfo. That will allow us to remove even more. And since users can't create events in coracle any more, it doesn't make sense to let them edit/delete.

src/app/views/NoteCreate.svelte Show resolved Hide resolved
@ticruz38
Copy link
Collaborator Author

  • removed all things related to listing and calendar in NoteCreate
  • remove EventDetail and EventDelete and all actions/buttons/links referring it

@staab
Copy link
Collaborator

staab commented Nov 13, 2024

You should be able to completely remove EventActions and EventDetail. Be sure to remove the detailPath stuff in EventInfo as well.

@ticruz38
Copy link
Collaborator Author

  • Removed EventDetail too
  • Kept EventAction only for the QR code sharing, if not, I'll remove EventActions completely

@staab
Copy link
Collaborator

staab commented Nov 18, 2024

Yeah, go ahead and remove EventActions completely. We can add qr code sharing to normal event share if we decide we want that down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants