-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove listings and events #468
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and remove the EventActions stuff, and the delete/edit links from EventInfo. That will allow us to remove even more. And since users can't create events in coracle any more, it doesn't make sense to let them edit/delete.
|
You should be able to completely remove EventActions and EventDetail. Be sure to remove the |
1b52261
to
d3631ff
Compare
|
e9b8a69
to
5377973
Compare
5377973
to
354b64a
Compare
Yeah, go ahead and remove EventActions completely. We can add qr code sharing to normal event share if we decide we want that down the line. |
Removing calendar events as well as the @Event-calendar dependency.
EventDetail, EventEdit and EventDelete are still accessible via an Event Note so they remain.
#452
#453