Creation and Submission delay and status #457

ticruz38 · 2024-10-31T15:51:30Z

This PR address issues #369 and #235

New setting to delay the publishing of a note (default is 0)
Cancelable toast when creating a new note
Inline Note status when replying to a note.

When replying, there is a (configurable) 5 seconds countdown before the note is sent

Once the note is sent, it tracks the pending requests via a loading bar

Once all request are settled, it shows a status summary, with the possibility to open a more detailed modal

The post status is displayed for 30 seconds, after which the actions buttons shows up like a normal note

staab · 2024-10-31T16:25:58Z

This diff is wonky too. For some reason it's showing all my commits as your commits. I don't know what you're doing to make that happen, but can you reset/rebase to clean it up?

staab

You'll need to rebase this on dev since I merged the groups stuff. Also, take a look at @welshman/app's thunk module, it solves a lot of these problems much more cleanly. I'm not sure if we can integrate it cleanly yet, but see if you run into any problems with that.

src/app/shared/Note.svelte

src/util/misc.ts

src/app/shared/Note.svelte

ticruz38 · 2024-11-06T14:23:55Z

thunk module, it solves a lot of these problems much more cleanly. I'm not sure if we can integrate it cleanly yet, but see if you run into any problems with that.

So I tried, for the NoteCreate, it's ok, I can watch the thunk status and take action depending on it (clear the modal, show the toaster etc).
EDIT: No I need a callback, the thunk status or result only resolved once the relay replied, I need either one more status (SENT?) or a callback.

The canceled is handled with thunk.controller.abort(). Which is cleaner than keeping a cancel state in the component.

For the reply, it's feasible too but the thunk will have to travel across 3 or 4 components like this.
NoteReply > Note(parent) > Note(reply) > NotePending

Atm I am using the publish command that populates the $publishes store, I can then import directly in NotePending and check out the state of my pub. It seems cleaner.

staab · 2024-11-07T23:24:39Z

EDIT: No I need a callback, the thunk status or result only resolved once the relay replied, I need either one more status (SENT?) or a callback.

Look for the Pending status, that gets set when the event is first sent to the relay. If pub.status is empty, that means the event hasn't been sent yet. You should also be able to pass delay to the thunk to handle the timeout.

For the reply, it's feasible too but the thunk will have to travel across 3 or 4 components like this.
NoteReply > Note(parent) > Note(reply) > NotePending

I'm actually hoping to migrate from publishes to thunks (which are a superset of the functionality), this issue is actually a step in that migration. We can just add these to engine/state so they're available from anywhere. If you want to go ahead and do that migration as part of this issue, and get rid of publishes entirely, go ahead, they're only used in a couple places.

ticruz38 · 2024-11-08T18:02:50Z

ok I'll make the migration to thunk, almost there

ticruz38 · 2024-11-12T13:20:58Z

Just finished the thunk migration and rebased from dev

Might be worth another look

staab

When delay = 0, the tooltip still shows while the remote signer responds:

Not sure why, but a duplicate thunk is getting added with an undefined ID:

staab · 2024-11-07T22:17:16Z

.husky/pre-commit

@@ -1 +1 @@
-npm run check
+npm run format && npm run check


Suggested change

npm run format && npm run check

npm run check

src/app/views/UserSettings.svelte

src/partials/Toast.svelte

src/app/shared/Note.svelte

.husky/pre-commit

src/app/shared/Note.svelte

src/engine/state.ts

- slider to define send_delay

staab · 2024-11-18T18:22:32Z

src/app/shared/NoteActions.svelte

@@ -138,7 +133,7 @@
        id: note.id,
        anonymous: Boolean(note.wrap),
      })
-      .cx({callback: addToContext})
+      .cx({callback: repository.publish})


This can actually be removed. We might be able to get rid of callback from Zap as well if it's not used anywhere else.

staab · 2024-11-18T18:43:16Z

src/partials/ThunkStatus.svelte

+  $: total = thunk.request.relays.length
+  $: pending = Object.values($status).filter(s => s.status === PublishStatus.Pending).length


This needs to remove LOCAL_RELAY_URL from the count

staab · 2024-11-18T18:51:56Z

src/app/views/NoteCreate.svelte

@@ -139,11 +140,28 @@
          ],
        }),
    })
+    const thunk = publish({
+      event: template,
+      relays: ctx.app.router.PublishEvent(template).getUrls(),


This template doesn't have a pubkey yet, so random relays are selected. You'll need to sign the event first.

Also, when using nip 46, there's a pretty long delay before a note gets published. This isn't really part of this PR, but go ahead and add loading to NoteCreate to avoid double publishes.

staab · 2024-11-18T18:53:04Z

src/app/views/UserSettings.svelte

+    <Field>
+      <div slot="label" class="flex justify-between">
+        <strong>Send Delay</strong>
+        <div>{values.send_delay} ms</div>
+      </div>
+      <Input type="range" step="500" bind:value={values.send_delay} min={0} max={15_000}></Input>
+      <p slot="info">A delay period allowing you to cancel a reply or note creation, in seconds.</p>
+    </Field>


Let's display seconds instead of ms. A step of 1 is fine

staab · 2024-11-18T18:54:04Z

src/engine/state.ts

-export const publishes = withGetter(writable<Record<string, PublishInfo>>({}))
+export const groupHints = withGetter(writable<Record<string, string[]>>({}))


groupHints is old code, it can be removed

staab · 2024-11-18T18:55:45Z

src/partials/Toast.svelte

-  {#key "key"}
+  {#key $toast.id}


This was actually correct, it's to avoid an animation when there is already a toast visible. Unless something changed?

ticruz38 changed the base branch from master to dev October 31, 2024 15:56

ticruz38 marked this pull request as ready for review October 31, 2024 15:56

ticruz38 requested a review from staab October 31, 2024 15:56

ticruz38 force-pushed the feat/undo branch from ba2f893 to 6b71329 Compare November 1, 2024 09:06

staab reviewed Nov 6, 2024

View reviewed changes

src/app/shared/Note.svelte Outdated Show resolved Hide resolved

src/util/misc.ts Outdated Show resolved Hide resolved

src/app/shared/Note.svelte Outdated Show resolved Hide resolved

ticruz38 force-pushed the feat/undo branch from dfb0d3d to 0161b81 Compare November 6, 2024 14:00

ticruz38 force-pushed the feat/undo branch from 14311b2 to 3cd0b87 Compare November 12, 2024 13:03

staab reviewed Nov 13, 2024

View reviewed changes

ticruz38 added 13 commits November 15, 2024 10:33

add cancelable delay to reply and create note

007a6ab

final tweaks

916578f

remove note state from event object

16fb610

clearInterval on store

acb07d6

format and check

eb234e1

missing a status or a callback

4af4f2e

missing import

8d03763

use thunk for NoteCreate

d0eef27

use thunks in replies

3bf75d1

migrate from publishes

577fbab

rebase and check

ceb8b9d

- get rid of context in Note

65bcce9

- slider to define send_delay

bring the check back

b666329

ticruz38 force-pushed the feat/undo branch from 4c61848 to b666329 Compare November 15, 2024 09:34

use @welshman/app thunks store

08b1cdd

staab reviewed Nov 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creation and Submission delay and status #457

Creation and Submission delay and status #457

ticruz38 commented Oct 31, 2024 •

edited

Loading

staab commented Oct 31, 2024

staab left a comment

ticruz38 commented Nov 6, 2024 •

edited

Loading

staab commented Nov 7, 2024

ticruz38 commented Nov 8, 2024

ticruz38 commented Nov 12, 2024

staab left a comment

staab Nov 7, 2024

staab Nov 18, 2024

staab Nov 18, 2024

staab Nov 18, 2024

staab Nov 18, 2024

staab Nov 18, 2024

staab Nov 18, 2024

staab Nov 18, 2024

		$: total = thunk.request.relays.length
		$: pending = Object.values($status).filter(s => s.status === PublishStatus.Pending).length

		export const publishes = withGetter(writable<Record<string, PublishInfo>>({}))
		export const groupHints = withGetter(writable<Record<string, string[]>>({}))

Creation and Submission delay and status #457

Are you sure you want to change the base?

Creation and Submission delay and status #457

Conversation

ticruz38 commented Oct 31, 2024 • edited Loading

staab commented Oct 31, 2024

staab left a comment

Choose a reason for hiding this comment

ticruz38 commented Nov 6, 2024 • edited Loading

staab commented Nov 7, 2024

ticruz38 commented Nov 8, 2024

ticruz38 commented Nov 12, 2024

staab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ticruz38 commented Oct 31, 2024 •

edited

Loading

ticruz38 commented Nov 6, 2024 •

edited

Loading