Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing feedback messages to be appended #874

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Durbatuluk1701
Copy link
Contributor

This PR changes the behavior of handlings feedback messages to append the message rather than prepend them.
 
This should specifically fix #873

@Durbatuluk1701
Copy link
Contributor Author

One thing I also noticed while debugging this was that it seems to me like debug auto gets broken up into many different messages and events. Maybe at some point we could explore a more efficient solution of processing one large event/message since all the currently generated events/messages apply to the same range and have the same severity?

@rtetley
Copy link
Collaborator

rtetley commented Aug 26, 2024

Thanks !

@rtetley rtetley merged commit 76e99bf into coq:main Aug 26, 2024
24 checks passed
@rtetley
Copy link
Collaborator

rtetley commented Aug 26, 2024

One thing I also noticed while debugging this was that it seems to me like debug auto gets broken up into many different messages and events. Maybe at some point we could explore a more efficient solution of processing one large event/message since all the currently generated events/messages apply to the same range and have the same severity?

I agree this could be a good idea. Could you write it up in an issue to track this ?

@Durbatuluk1701 Durbatuluk1701 deleted the reversed-output-fix branch August 26, 2024 12:55
@gares
Copy link
Member

gares commented Aug 26, 2024

I suspect that for long output, like auto traces, it is better to still prepend but rev when displaying (less allocations, better complexity)

@Durbatuluk1701
Copy link
Contributor Author

I suspect that for long output, like auto traces, it is better to still prepend but rev when displaying (less allocations, better complexity)

I was a bit worried that if any other tools ever tried to interact with vscoqtop they might be confused unless they also reversed feedback messages client side.
If you think it is worth it though I can definitely try the prepend and rev client-side approach.
Also might be worth considering if the append price is too high if #878 works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug output is printed reverse
3 participants