Added more moderation UI complete with user blocking/ignoring #3119
Conversation
|
Pics? Workflow? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
| const role = model.get('role') ?? 'none'; | ||
| const affiliation = model.get('affiliation'); | ||
|
|
||
| const ownRole = muc.getOwnRole(); |
There was a problem hiding this comment.
It turns out that this variable is not needed since only applicable commands are considered,
and mute, kick, etc are not applicable to non moderators. So this variable factors out.
| api.unblockUser([jid]); | ||
| }; | ||
| let handleKick = (ev) => { | ||
| setRole(muc, 'kick', jid, [], ['moderator']); |
There was a problem hiding this comment.
Forgot to export setRole and verifyAndSetAffiliation from the other file
| const adminButton = html`<button class='btn btn-primary' @click=${handleAdmin}>Make Admin</button>` | ||
| const ownerButton = html`<button class='btn btn-primary' @click=${handleOwner}>Make Owner</button>` | ||
|
|
||
| // The following table stores a map from Affiliation x Role -> Button |
There was a problem hiding this comment.
Should clarify, the mapping is from OwnAffiliation x { Target's Current Affiliation, Target's Current Role } -> Button
| @@ -0,0 +1,10 @@ | |||
| import { _converse, api, converse } from "@converse/headless/core.js"; | |||
|
|
|||
| const { Strophe, $iq } = converse.env; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
|
I've rebased and made some updates here: https://github.com/conversejs/converse.js/pull/ Closing this PR in favor of that one. |
Thanks for making a pull request to converse.js!
Before submitting your request, please make sure the following conditions are met:
CHANGES.mddocument it in
docs/source/configuration.rstwith
make checkor you can run them in the browser by runningmake serveand then opening
http://localhost:8000/tests.html.