WIP: Audio video capability #2956
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawBud
force-pushed
the
audio-video-capibility
branch
from
f31c052 to
fdc537d
Compare
jcbrand
requested changes
Jun 20, 2022
PawBud
force-pushed
the
audio-video-capibility
branch
from
098a817 to
0c6b78e
Compare
|
This pull request introduces 2 alerts when merging 53e2cdd into a95c070 - view on LGTM.com new alerts:
|
EventHookListener: added an event listener to the jingle plugin
PawBud
force-pushed
the
audio-video-capibility
branch
from
34dd28f to
4eb696e
Compare
|
This pull request introduces 2 alerts when merging ee9da60 into 3ca478d - view on LGTM.com new alerts:
|
jcbrand
requested changes
Jul 11, 2022
jcbrand
requested changes
Jul 11, 2022
PawBud
commented
Jul 18, 2022
PawBud
commented
Jul 26, 2022
jcbrand
reviewed
Sep 6, 2022
| } | ||
|
|
||
| export function getJingleTemplate(model) { | ||
| return html`<converse-jingle-message jid='${model.get('jingle_status')}'></converse-jingle-message>`; |
There was a problem hiding this comment.
You're not passing in the jid of the contact here, you're passing in model.get('jingle_status').
That's most likely why you're not getting the model in the component.
|
@PawBud why you removed your assignee ? |
I can't work on this issue anytime soon given my commitments, so for now anyone who wants to pick it up, feel free to do so! |
|
@PawBud: Can you look to finish your PR 2 years after? Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.