Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print full dockerfile path instead of context on error #796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Print full dockerfile path instead of context on error #796

wants to merge 1 commit into from

Conversation

siteshwar
Copy link

... if the dockerfile is not found.

@siteshwar
Print full dockerfile path instead of context on error
3c3829d 
... if the dockerfile is not found.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Copy link
Author

Current error message is confusing and does not provide the exact path where the dockerfile is being searched. This change should help in debugging such cases.

p12tic
p12tic requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Could you please add examples of previous error message and current error message to the commit message? Also, the first line of the commit message needs to be 72 characters or less, otherwise it's hard wrapped by tools and people see broken sentence.

Also, please rebase on top of latest main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic p12tic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siteshwar @p12tic