Add support for cross-file service dependency #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1gbear
force-pushed
the
devel
branch
2 times, most recently
from
168e8e1
to
8a6a07e
Compare
Signed-off-by: Szymon Niedzwiedz <[email protected]>
|
@muayyad-alsadi ping, what do you think about this pull request? |
|
@muayyad-alsadi This PR adds tests and solves few issues, could you, please, take a look? |
|
Hi @b1gbear, not sure what's the maintainer's opinion here but for me it'd make more sense to split this PR on a per-bug-fix fashion so it's easier to review and potentially merge. |
|
I agree, I need to understand the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends -> file used more than once does not work in podman-compose correctly for 2nd and next services #465
Add tests for:
Share your thoughts, please.