podman-compose down removes networks #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdgroot
force-pushed
the
down_removes_network
branch
from
ad6251c
to
a6c7b95
Compare
p12tic
reviewed
Oct 19, 2024
| @@ -187,3 +187,33 @@ def test_down_with_orphans(self): | |||
| ], | |||
| 1, | |||
| ) | |||
|
|
|||
| def test_down_with_network(self): | |||
| up_cmd = [ | |||
There was a problem hiding this comment.
Could you put the commands to inside relevant run_subprocess_assert_returncode?
I do understand you copied the style from the tests, we will fix this inconsistency eventually.
p12tic
requested changes
Oct 19, 2024
tdgroot
force-pushed
the
down_removes_network
branch
2 times, most recently
from
6d07f79
to
27dc6fe
Compare
Fixes containers#490 Signed-off-by: Timon de Groot <[email protected]>
tdgroot
force-pushed
the
down_removes_network
branch
from
27dc6fe
to
db0aad9
Compare
|
@p12tic thanks for your review! I changed the test to reflect the new style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490