Make minor changes to spec file for fedora-review #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran fedora-review on the 0.96 package and went through the results for items which were called out. Changes needed were to bring permissions to Fedora standards and making ownerships of directories and files clear. Signed-off-by: Stephen Smoogen <[email protected]>
smooge
requested review from
ericcurtin,
rhatdan,
dougsland and
masneyb
as code owners
ericcurtin
reviewed
Nov 8, 2023
| Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz | ||
|
|
||
| BuildRequires: gcc | ||
| Recommends: erofs-utils | ||
| Requires: dracut |
There was a problem hiding this comment.
This is a "Requires" as of today, I hope to make this a Recommends in future, there's no reason we couldn't use something like https://github.com/systemd/mkosi-initrd instead in future if someone wanted to use that as an alternative tool.
There was a problem hiding this comment.
I put it in so that a warning on directories owned by the dracut package /usr/lib/dracut/modules.d/ but expected to be there by this package. But if that part goes away or needs to go into a sub package in the future, that is easy enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran fedora-review on the 0.96 package and went through the results for items which were called out. Changes needed were to bring permissions to Fedora standards and making ownerships of directories and files clear.