-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initoverlayfs-install: generic improvements #10
Conversation
Just spend some time on the weekend reading and testing the |
The CI/CD still failing, need to address some others scripts this week. |
All good:
|
Only gave a skip as I'm off, but looks cleaner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add back in the fail in ext4 thing (it's untested, I'm almost sure it doesn't work, although it wouldn't be too much effort to make it work, it's not the focus), this should be good to go. Note ASCII colors and is nice to have, but when we have a more complete initoverlayfs solution, users will not manually call initoverlayfs-install at all, it will just run in the background automatically when appropriate (like dracut -f does).
- split extract_initrd_into_initoverlayfs() - remove unneeded |--* in case statement - replace initoverlayfs_conf with constant - remove unused no_kern - fix some shellcheck warnings Signed-off-by: Douglas Schilling Landgraf <[email protected]>
shellcheck failed, but it's failing everywhere at present |
Fixes: #11
Fixes: #12